> The most time I spent figuring out how I best get the ADD CONSTRAINT
> clause into the middle of the SQL string; hsqldb requires this. Current
> version has a cut'n paste copy of the createFkConstraint() method with
> one change in it: it uses a new method
> getConstraintNameForRelationship(). If we could pull this up into the
> superclass and have it return null as default I could just delete the
> pasted version of createFkConstraint() from HSQLDBAdapter. Sounds
> reasonable?
My opinion is that lots of SQL semantics (and esp. DDL) is very hard to
describe in a clean OO terms. So I think cut'n'paste is totally acceptable
in this particular case and is probably preferrable to any unnatural
generalization.
> Another question: CayenneTestDatabaseSetup uses WARN for logging the
> ALTER TABLE statements; any reason not to make this INFO, so that it is
> more consistent with other logging output?
+1. Lets do it.
Andrus
This archive was generated by hypermail 2.0.0 : Mon Feb 10 2003 - 15:56:46 EST