Re: [JIRA] Commented: (CAY-926) Refactoring class generator classes

From: Andrus Adamchik (andru..bjectstyle.org)
Date: Sun Dec 02 2007 - 09:37:24 EST

  • Next message: Kevin Menard: "Re: [JIRA] Commented: (CAY-926) Refactoring class generator classes"

    That's been taken care of by deprecating CayenneGenerator and making
    it a subclass of new CayenneGeneratorTask. The rest of the classes are
    sort of private to the framework (the only known external user of this
    API is WOProject wogen task), and anyways, I am following the
    deprecation path in almost all cases.

    Andrus

    On Dec 2, 2007, at 4:30 PM, Kevin Menard (JIRA) wrote:

    >
    > [ https://issues.apache.org/cayenne/browse/CAY-926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel
    > #action_12610 ]
    >
    > Kevin Menard commented on CAY-926:
    > ----------------------------------
    >
    > While I agree that the ant class name could be better named, just be
    > careful with that one. Renaming the class could break a lot of
    > existing code as the fully qualified name is apt to be specified to
    > load the task.
    >
    >> Refactoring class generator classes
    >> -----------------------------------
    >>
    >> Key: CAY-926
    >> URL: https://issues.apache.org/cayenne/browse/CAY-926
    >> Project: Cayenne
    >> Issue Type: Improvement
    >> Components: Cayenne Core Library
    >> Affects Versions: 3.0
    >> Reporter: Andrus Adamchik
    >> Assignee: Andrus Adamchik
    >> Priority: Minor
    >> Fix For: 3.0
    >>
    >>
    >> I am going to do some renaming and code refactoring to make class
    >> generator code easier to extend. Here is a few points I am planning
    >> to work on:
    >> 1. Naming. CayenneGenerator, ClassGenerator, MapClassGenerator are
    >> all independent classes, none inheriting from each other. Just by
    >> looking at the name , it is impossible to tell that
    >> CayenneGenerator is an ant task, ClassGenerator is a template
    >> processor, and MapClassGenerator is a controller for multiple
    >> templates
    >> 2. Version 1.1 vs. version 1.2... Ideally we should get rid of the
    >> versions, but for now it would be nice to may be nice to just split
    >> different version handlers into different subclasses... Don't have
    >> a clear idea yet how to do it...
    >
    > --
    > This message is automatically generated by JIRA.
    > -
    > You can reply to this email to add a comment to the issue online.
    >
    >



    This archive was generated by hypermail 2.0.0 : Sun Dec 02 2007 - 09:37:56 EST