[jira] Commented: (CAY-1062) Code Generation line ending consistency: ImportUtils

From: Andrus Adamchik (JIRA) ("Andrus)
Date: Sun Jun 01 2008 - 16:34:52 EDT

  • Next message: Kevin Menard (JIRA): "[jira] Commented: (CAY-1062) Code Generation line ending consistency: ImportUtils"

        [ https://issues.apache.org/cayenne/browse/CAY-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890#action_12890 ]

    Andrus Adamchik commented on CAY-1062:
    --------------------------------------

    I guess we haven't received any complaints from Windows users so far about the line endings, as Java compilers and Eclipse don't care much about them, and make it transparent. So I went for consistency, as mixed line endings are causing me pain already (and UNIX line endings are transparent to Windows users).

    But I totally agree with your general point, and if somebody's willing to implement platform-specific Velocity template line endings (maybe via postprocessing of generated files?) , and document the SVN tricks for cross-platform development on a cgen page of the docs, I have no objections, although the value likely will be mariginal.

    > Code Generation line ending consistency: ImportUtils
    > ----------------------------------------------------
    >
    > Key: CAY-1062
    > URL: https://issues.apache.org/cayenne/browse/CAY-1062
    > Project: Cayenne
    > Issue Type: Bug
    > Components: Cayenne Core Library
    > Affects Versions: 3.0
    > Reporter: Andrus Adamchik
    > Assignee: Andrus Adamchik
    > Priority: Trivial
    > Fix For: 3.0
    >
    >
    > ImportUtils should use UNIX line ending when generating imports in 'generate'... Otherwise classes generated on UNIX and Windows will differ in line endings, and in a developer group that is a mix of windows/unix/mac, people will constantly override each other. Note that the rest of the template ensures line ending consistency, it is only the ImportUtils that use platform-specific endings.

    -- 
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
    



    This archive was generated by hypermail 2.0.0 : Sun Jun 01 2008 - 16:35:17 EDT