[jira] Closed: (CAY-1060) CM: Allow multiple item selections

From: Kevin Menard (JIRA) ("Kevin)
Date: Sat Jun 21 2008 - 14:26:53 EDT

  • Next message: Kevin Menard (JIRA): "[jira] Reopened: (CAY-1060) CM: Allow multiple item selections"

         [ https://issues.apache.org/cayenne/browse/CAY-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

    Kevin Menard closed CAY-1060.
    -----------------------------

        Resolution: Fixed

    I've applied patch #2, with minor cleanups. Please don't use underscores in variables names -- use camel case. Please place spaces between control keywords and opening parens (i.e., "if (" rather than "if(" ) and please always enclose control statement bodies in braces.

    Otherwise, the code looked quite good. It took me a while to understand some of it due to the overall lack of comments. Since the original code wasn't commented very well, it's hard to fault the submitter, but comments should be part of any patch submission.

    > CM: Allow multiple item selections
    > ----------------------------------
    >
    > Key: CAY-1060
    > URL: https://issues.apache.org/cayenne/browse/CAY-1060
    > Project: Cayenne
    > Issue Type: Improvement
    > Components: CayenneModeler GUI
    > Affects Versions: 3.0
    > Reporter: Andrey Razumovsky
    > Assignee: Kevin Menard
    > Attachments: patch-CAY-1060-2.txt, patch-CAY-1060.txt
    >
    >
    > Allow multiple item selections on the left-hand project tree and right-hand attribute panels. Common operations (like "delete") should work on multiple objects.
    > This is GSoC 2008 task

    -- 
    This message is automatically generated by JIRA.
    -
    You can reply to this email to add a comment to the issue online.
    



    This archive was generated by hypermail 2.0.0 : Sat Jun 21 2008 - 14:27:19 EDT