Re: [jira] Updated: (CAY-1298) String no longer works in query when column type is Integer

From: Andrus Adamchik (andru..bjectstyle.org)
Date: Mon Jan 11 2010 - 14:53:19 EST

  • Next message: Andrus Adamchik: "Re: [jira] Updated: (CAY-1298) String no longer works in query when column type is Integer"

    On Jan 11, 2010, at 9:39 PM, Andrey Razumovsky wrote:

    > Actually I've been using such syntax myself (we also talked about
    > that when
    > discussing generified expressions).

    yes, but I wish we define an explicit set of allowed conversions that
    work the same across DB's (by virtue of Cayenne doing those
    conversions). E.g. we'd require format string for Date conversions, etc.

    > I really want this ability to stay in
    > some way, since it saves time and unnecessary code. Currently it
    > works for
    > me in MySQL when id column is BIGINT (and I'm searching by a
    > string). Most
    > DBMS allow comparing string to an int, why shouldn't we?

    My problem with this is consistency. The patch will work or fail
    depending on a specific driver (or a driver version - something I
    observed on postgresql in the past), and a specific type of String to
    X conversion. Actually the current 'setString' approach is prone to
    the same problem, but changing it now opens possibility of new
    regression issues. So we'll be likely fixing a subset of cases and
    breaking some other subset, and that won't be clear immediately.

    Andrus



    This archive was generated by hypermail 2.0.0 : Mon Jan 11 2010 - 14:53:55 EST