Re: svn commit: r935207 - in /cayenne/main/trunk: docs/doc/src/main/resources/ framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/query/ framework/cayenne-jdk1.5-unpublished/src/test/java/org/apache/cayenne/query/

From: Evgeny Ryabitskiy (evgeny.ryabitski..mail.com)
Date: Sun Apr 18 2010 - 07:31:51 EDT

  • Next message: Andrey Razumovsky: "3.0 final?"

    This was add to fix another JUnit test (that was failing).
    JUnit test was expecting that this flag is false while use setFatchingDataRows.
    So I add it here, to didn't change previous behavior
    Maybe I didn't understand the meaning of SQLResult....

    Evgeny.

    2010/4/18 Andrus Adamchik <andru..bjectstyle.org>:
    >
    > On Apr 18, 2010, at 12:46 AM, evgen..pache.org wrote:
    >
    >>    public void setResult(SQLResult resultSet) {
    >> +        setFetchingDataRows(false); // turn off mapping to DataRows, use
    >> explicit
    >>        this.result = resultSet;
    >>    }
    >
    > Implicit flipping of the DataRows flag outside constructor seems
    > counterintuitive. Also SQLResult is not equal to an object fetch. So I think
    > this is wrong.
    >
    > Andrus



    This archive was generated by hypermail 2.0.0 : Sun Apr 18 2010 - 07:32:39 EDT