Re: r4761 - trunk/woproject/wolips/core/plugins/org.objectstyle.wolips.eogenerator.core/templates

From: Lachlan Deck (lachlan.dec..mail.com)
Date: Sun Jan 13 2008 - 05:53:13 EST

  • Next message: Paul Charles Leddy: "Build frameworks as jars in Eclipse"

    On 13/01/2008, at 3:54 AM, Anjo Krank wrote:

    > Hm, just use
    >
    > public class MyEO ..
    > public interface Key {
    > public String FOO_KEY = ...;
    > public ERXKey foo = ...;
    > }
    > }
    >
    > and then eo.valueForKey(MyEO.Key.foo)...

    Isn't it unusual using lowercase for constants? Perhaps initial
    capital camel case is nicer. e.g., FooBarKey

    Just a thought.

    > Am 12.01.2008 um 17:34 schrieb mschra..bjectstyle.org:
    >
    >> Author: mschrag
    >> Date: 2008-01-12 11:34:18 -0500 (Sat, 12 Jan 2008)
    >> New Revision: 4761
    >>
    >> Modified:
    >> trunk/woproject/wolips/core/plugins/
    >> org.objectstyle.wolips.eogenerator.core/templates/_WonderEntity.java
    >> Log:
    >> I like how it looks lowercase but it generates tons of attribute
    >> hiding warnings
    >>
    >> Modified: trunk/woproject/wolips/core/plugins/
    >> org.objectstyle.wolips.eogenerator.core/templates/_WonderEntity.java
    >> ===================================================================
    >> --- trunk/woproject/wolips/core/plugins/
    >> org.objectstyle.wolips.eogenerator.core/templates/
    >> _WonderEntity.java 2008-01-09 16:17:06 UTC (rev 4760)
    >> +++ trunk/woproject/wolips/core/plugins/
    >> org.objectstyle.wolips.eogenerator.core/templates/
    >> _WonderEntity.java 2008-01-12 16:34:18 UTC (rev 4761)
    >>.. -23,13 +23,13 @@
    >> // Attributes
    >> #foreach ($attribute in $entity.sortedClassAttributes)
    >> public static final String ${attribute.uppercaseUnderscoreName}
    >> _KEY = "$attribute.name";
    >> - public static final ERXKey ${attribute.name} = new ERXKey($
    >> {attribute.uppercaseUnderscoreName}_KEY);
    >> + public static final ERXKey ${attribute.uppercaseUnderscoreName}
    >> = new ERXKey(${attribute.uppercaseUnderscoreName}_KEY);
    >> #end
    >>
    >> // Relationships
    >> #foreach ($relationship in $entity.sortedClassRelationships)
    >> public static final String ${relationship.uppercaseUnderscoreName}
    >> _KEY = "$relationship.name";
    >> - public static final ERXKey ${relationship.name} = new ERXKey($
    >> {relationship.uppercaseUnderscoreName}_KEY);
    >> + public static final ERXKey $
    >> {relationship.uppercaseUnderscoreName} = new ERXKey($
    >> {relationship.uppercaseUnderscoreName}_KEY);
    >> #end
    >>
    >> private static Logger LOG = Logger.getLogger($
    >> {entity.prefixClassNameWithoutPackage}.class);

    with regards, 

    --

    Lachlan Deck

    This archive was generated by hypermail 2.0.0 : Sun Jan 13 2008 - 05:54:17 EST