Patch applied. Thanks a lot!
I added a few unit tests for iterators and also performed some
refactoring, namely:
1. Renamed fetchSize to maxFetchSize (I guess this way there will be
less confusion with pageSize)
2. Added "setMaxFetchSize". Even though user will be able to call this
only after the first page is resolved, this still gives users enough
control, since in 99.999% cases pageSize < maxFetchSize
3. Refactored inline ListIterator implementation into a nested class,
so that there is no code duplication in listIterator() vs.
listIterator(int)
Andrus
On Friday, September 26, 2003, at 02:22 PM, Scott Finnerty wrote:
> Attached is a patch for IncrementalFaultList that:
>
> 1) provides iterator implementations that support the incremental
> fetches
> from the database.
>
> 2) ensures that resolving a range in the list is done in chunks so as
> to
> mitigate statement length and/or complexity limitations in drivers
> (such as
> PostgreSQL's limit on expression nesting)
>
> Note: the default chunk size is 10000 - I picked this because of the
> default
> limit in PostgreSQL.
>
> Still to do:
>
> 1) testing the various iterators thoroughly.
>
> 2) making the "chunk" size - i.e., fetchSize - configurable.
>
> Scott Finnerty
> <IncrementalFaultList-20030926.patch>
This archive was generated by hypermail 2.0.0 : Sun Sep 28 2003 - 15:50:09 EDT