At the moment, in cayenne-java, Eclipse is telling me 0 errors, 300
warnings (Filter matched 300 of 696 items). So, I've limited myself to
the first 300 "problems" and I also filter to the current project, so
that's 696 warnings in one project ... As of a few days ago, at least,
when I last did an update.
Most of the ones I am seeing are local variables (or parameters) are
hiding instance variables. And some unnecessary casts. And it likes to
complain about constants: JLabel.CENTER should be SwingConstants.CENTER
(according to Eclipse).
/dev/mrg
-----Original Message-----
From: Andrus Adamchik [mailto:andru..bjectstyle.org]
Sent: Thursday, March 02, 2006 12:48 AM
To: cayenne-deve..bjectstyle.org
Subject: Re: Cayenne/Windows developer help
Yeah, please go ahead and commit that. I didn't realize we had any of
those. I thought all the remaining warnings are due to the fact that
we have to keep deprecated stuff around. But since three people
independently confirm that there are unused imports and local vars, I
am probably wrong or haven't been paying attention.
Andrus
On Mar 2, 2006, at 6:48 AM, Kevin Menard wrote:
> I actually went through and cleaned a fair number of these up, but
> haven't
> committed anything yet. So, I can check those in so work doesn't get
> duplicated.
>
> I've found it a bit annoying too. I tend to set things like unused
> imports
> and unused local vars to be errors. I had to go through and change
> all my
> settings for Cayenne though . . .
>
> --
> Kevin
>
>
> On 3/1/06 4:43 PM, "Cris Daniluk" <cris.danilu..mail.com> wrote:
>
>> I am equally annoyed by the warnings. Some are legit because
>> Eclipse's
>> default warning settings are obnoxious, and some are required because
>> deprecated features haven't been entirely removed from the project,
>> but some can be fixed.
>>
>> Is it okay to fix them where possible? Unused imports/local vars,
>> etc..
>>
>> On 3/1/06, Gentry, Michael (Contractor)
>> <michael_gentr..anniemae.com> wrote:
>>> I understand. I keep forgetting to set my Java compiler to 1.5
>>> before
>>> running Ant when building Cayenne.
>>>
>>> On a slightly different note (to everyone), I get a LOT of
>>> warnings when
>>> I'm using Eclipse. Do you see the same? I went into the project
>>> properties and told it to use the local settings instead of the
>>> global
>>> settings, but I still see lots of warnings. If you see those
>>> too, do
>>> you think there is any interest in cleaning them up? I
>>> personally like
>>> 0 warnings in my projects.
>
>
>
This archive was generated by hypermail 2.0.0 : Thu Mar 02 2006 - 09:26:59 EST