[JIRA] Commented: (CAY-958) cgen ant task generates nonsense if superpkg attribute is missing, should fail instead

From: Andrus Adamchik (JIRA) ("Andrus)
Date: Wed Jan 09 2008 - 10:55:32 EST

  • Next message: Andrus Adamchik (JIRA): "[JIRA] Closed: (CAY-958) cgen ant task generates nonsense if superpkg attribute is missing, should fail instead"

        [ https://issues.apache.org/cayenne/browse/CAY-958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677#action_12677 ]

    Andrus Adamchik commented on CAY-958:
    -------------------------------------

    IIRC I observed this behavior too and agree that we should use either the subclass package or the DataMap package. Not that class generation code underwent very significant changes since M2, but I believe this problem is still around and needs to be addressed.

    > cgen ant task generates nonsense if superpkg attribute is missing, should fail instead
    > --------------------------------------------------------------------------------------
    >
    > Key: CAY-958
    > URL: https://issues.apache.org/cayenne/browse/CAY-958
    > Project: Cayenne
    > Issue Type: Bug
    > Affects Versions: 3.0
    > Environment: should not matter, but XP SP2 with all latest, sun java 1.6.0_03
    > Reporter: Michael Bergens
    > Assignee: Andrus Adamchik
    >
    > with the 3.0M2 Cayenne distro, this ant task:
    > <cgen map="${db.map}" destdir="${src.dir}" overwrite="false" encoding="UTF-8" version="1.2"/>
    > generates classes with "package null" thus placing superclasses (classes with underscore) in the source root.
    > If I change it to:
    > <cgen map="${db.map}" destdir="${src.dir}" overwrite="false" encoding="UTF-8" version="1.2"
    > superpkg="com.mycompany.schema"/>
    > Then it all works. The UI tool generates classes with the same maps just fine. Something is missing here:
    > 1. If the package happens to be null then the task should fail instead of completing normally with a hint of what's wrong.
    > 2. Should not the package be taken from the map file, from at least
    > <property name="defaultPackage" value="com.mycompany.schema"/>
    > ?
    > 

    -- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

    This archive was generated by hypermail 2.0.0 : Wed Jan 09 2008 - 10:55:55 EST