Re: svn commit: r616531 - in /cayenne/main/trunk/framework/cayenne-jdk1.5-unpublished/src/main/java/org/ apache/cayenne/exp/parser: ASTAnd.java ASTOr.java ASTSubtract.java

From: Kevin Menard (kmenar..ervprise.com)
Date: Tue Jan 29 2008 - 17:16:31 EST

  • Next message: Tore Halset: "Re: Unit Test Slowness [Re: 3.0 M3 test results]"

    Well, the types were tool generated. The one thing I did miss is using
    wildcards on these types though. I've been manually inspecting each one and
    applying wildcards to public methods on public classes. I'll fix that. 

    -- 
Kevin

    On 1/29/08 5:04 PM, "Aristedes Maniatis" <ar..aniatis.org> wrote:

    > 
> On 30/01/2008, at 8:56 AM, kmenar..pache.org wrote:
> 
>> +    public ASTAnd(Collection<Node> nodes) {
>> 
>> +    public ASTOr(Collection<Node> nodes) {
>> 
>> +    public ASTSubtract(Collection<Object> nodes) {
> 
> I haven't studied the code, but is that right? Should they be more
> consistently all Object or all Node?
> 
> Ari
> 
> 
> -------------------------->
> Aristedes Maniatis
> phone +61 2 9660 9700
> PGP fingerprint 08 57 20 4B 80 69 59 E2  A9 BF 2D 48 C2 20 0C C8
> 
>

    This archive was generated by hypermail 2.0.0 : Tue Jan 29 2008 - 17:17:04 EST