Re: static final classes?

From: Michael Gentry (blacknex..mail.com)
Date: Tue Oct 21 2008 - 13:09:16 EDT

  • Next message: Andrus Adamchik: "Fwd: git-svn dcommit of multiple changes"

    I'm OK with that, too. I'll make the updates soonish.

    Thanks!

    On Tue, Oct 21, 2008 at 12:20 PM, Andrus Adamchik
    <andru..bjectstyle.org> wrote:
    >
    > On Oct 21, 2008, at 11:31 AM, mgentr..pache.org wrote:
    >
    >> - public List get(QueryMetadata metadata) {
    >> + public List<?> get(QueryMetadata metadata) {
    >> String key = metadata.getCacheKey();
    >> if (key == null) {
    >> return null;
    >
    >
    > Michael,
    >
    > you may check this discussion on why returning List<?> from a method is a
    > bad idea:
    >
    > http://markmail.org/message/ts4zjelowa55nfgg
    > http://markmail.org/message/cp63by2swbdnfp7v
    >
    > I suggest..uppressWarnings("unchecked") instead.
    >
    > Thanks,
    > Andrus
    >
    >
    > On Oct 21, 2008, at 11:12 AM, Michael Gentry wrote:
    >
    >> I was doing a little cleanup under org.apache.cayenne.cache and
    >> FindBugs was issuing warnings about the final inner classes at the
    >> bottom of MapQueryCache.java (CacheEntry) and OSQueryCache.java
    >> (OSCacheAdministrator). Should these be declared as "final static
    >> class" instead of "final class"?
    >>
    >> Thanks!
    >>
    >
    >

    This archive was generated by hypermail 2.0.0 : Tue Oct 21 2008 - 13:10:11 EDT