Re: [jira] Commented: (CAY-1181) Default class generation folder is wrong

From: Robert Zeigler (robert.zeigle..mail.com)
Date: Tue Mar 03 2009 - 16:03:54 EST

  • Next message: Andrey Razumovsky: "Pre-insert callback?"

    Ok, the cayenne-modeler plugin now sets up the cayenne.cgen.destdir
    system property for use by the modeler.
    How close is dima to having the modeler remember the outputdir/
    override w/ the system property?

    Robert

    On Feb 21, 2009, at 2/219:02 AM , Robert Zeigler wrote:

    >
    > On Feb 21, 2009, at 2/218:34 AM , Andrus Adamchik wrote:
    >
    >> [forwarding to dev, as it is easier to discuss things on a mailing
    >> list compared to Jira]
    >>
    >> One of the guys I am working with, Dima Loiko, started some work on
    >> CAY-1181 Jira (again here we are dealing with the issue that I
    >> raised before: people who are interested in working on Cayenne but
    >> don't know English well enough to communicate on the list,
    >> resulting in a very un-Apache under-the-radar activity. Anyways I
    >> don't know how to overcome this problem now, so I will keep working
    >> as a proxy)...
    >>
    >>> Perhaps an additional command line argument, or via a system
    >>> property? Definitely interested in getting a bit of discussion
    >>> going on this b/c having to constantly change the output folder is
    >>> starting to get old; I have an itch to scratch on this one.
    >>
    >>
    >> I am +1 on creating an override for the default source generation
    >> folder that can be used when starting from Maven. Maybe you can
    >> handle the Maven side of things and Dima will pick it up on the
    >> Modeler end? Let's just agree on the property name. Modeler
    >> currently uses "cayenne.version" and "cayenne.build.date"
    >> properties. Maybe "cayenne.cgen.destdir" ?
    >>
    >
    > Happy to handle the maven side.
    > cayenne.cgen.destdir works for me.
    >
    > Robert
    >
    >> Andrus
    >>
    >>
    >>
    >>
    >>
    >> On Feb 21, 2009, at 6:11 AM, Robert Zeigler (JIRA) wrote:
    >>
    >>>
    >>> [ https://issues.apache.org/cayenne/browse/CAY-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251
    >>> #action_13251 ]
    >>>
    >>> Robert Zeigler commented on CAY-1181:
    >>> -------------------------------------
    >>>
    >>> Now that CAY-1158 is fixed, it would be /really/ nice if the
    >>> modeler would pick up the appropriate java source directory
    >>> automatically. One way to do this would be to code logic directly
    >>> into the modeler that checks for a maven-like structure and
    >>> "guesses" at src/main/java. But I'm not necessarily keen on this
    >>> approach; true, src/main/java is /usually/ where the folder is,
    >>> but that's not written in stone. In the context of CAY-1158,
    >>> where the modeler is being loaded directly by maven, it would be
    >>> nice to have an external method of specifying the class generation
    >>> folder. Perhaps an additional command line argument, or via a
    >>> system property? Definitely interested in getting a bit of
    >>> discussion going on this b/c having to constantly change the
    >>> output folder is starting to get old; I have an itch to scratch on
    >>> this one.
    >>>
    >>>> Default class generation folder is wrong
    >>>> ----------------------------------------
    >>>>
    >>>> Key: CAY-1181
    >>>> URL: https://issues.apache.org/cayenne/browse/CAY-1181
    >>>> Project: Cayenne
    >>>> Issue Type: Improvement
    >>>> Components: Cayenne Core Library
    >>>> Affects Versions: 3.0M5
    >>>> Reporter: Andrus Adamchik
    >>>> Assignee: Andrus Adamchik
    >>>>
    >>>> Default class generation folder in the modeler (Tools > Generate
    >>>> Classes > Output directory) is selected to be the folder where
    >>>> cayenne.xml is stored. If a user changes it, it is not saved in
    >>>> user preferences, so on the next attempt to generate classes the
    >>>> old folder is shown.
    >>>> Another related improvement: In a project that has Maven folder
    >>>> layout, cayenne.xml is often is src/main/resources. In this case
    >>>> we must select a default folder ot be src/mainjava (for "src/test/
    >>>> resources" it should be src/test/java). I.e. we should be smarter
    >>>> when we are dealing with predictable maven structures.
    >>>
    >>> --
    >>> This message is automatically generated by JIRA.
    >>> -
    >>> You can reply to this email to add a comment to the issue online.
    >>>
    >>>
    >>
    >



    This archive was generated by hypermail 2.0.0 : Tue Mar 03 2009 - 16:04:36 EST