Re: Adding enums?

From: Michael Gentry (mgentr..asslight.net)
Date: Fri Sep 25 2009 - 10:27:45 EDT

  • Next message: Andrus Adamchik: "Re: Adding enums?"

    I've started looking into this. How about calling the sorting
    direction enum Direction or SortOrder instead of Order? (I can see
    people using an ORM having an Order class already, which might be a
    bit confusing ... sorting your Orders by an Order ...) With the
    change, you'd end up with a constructor something like:

    public Ordering(String sortPathSpec, Direction/SortOrder sortingDirection) {...}

    I think we should fix the case sensitive flag while we are at it.
    Thoughts on the name for that one? Here is the constructor ...

    public Ordering(String sortPathSpec, Direction/SortOrder
    sortingDirection, boolean caseInsensitive) {...}

    One option is to make the Direction/SortOrder enum look something like:

    public enum Direction/SortOrder {
        ASCENDING, ASCENDING_INSENSITIVE, DESCENDING, DESCENDING_INSENSITIVE
    }

    Then you don't need the third parameter.

    Thanks,

    mrg

    This archive was generated by hypermail 2.0.0 : Fri Sep 25 2009 - 13:01:15 EDT