On Jan 11, 2010, at 1:45 PM, Рябицкий Евгений wrote:
> Strange result... looks like I have to install Postgress to check it
> myself... :)
>
> Evgeny.
Hi Evgeny,
looking at most test failures in Olga's tests, I see that most
failures are caused by various DB incompatibilities, and have nothing
to do with the change itself, but rather with the unit tests
themselves not being compatible with a given DB. Olga just logged one
issue (CAY-1363) that is actually a bug in Cayenne. Others are
similar, such as:
* MySQL truncating milliseconds (so the test has to be written to
compare with precision up to the nearest second)
* Precision and scale not declared for decimal values, causing loss of
precision in some DB's
* Max length for VARCHAR being 255 on some DBs
Those fairly benign issues would cause massive test failures, and
potentially hide the real issues. And those affect not only the
current patch, but also your earlier commit per http://svn.apache.org/viewvc?view=revision&revision=889168
We may need your help to make your tests compatible with other DB's.
Olga is about to send a patch on top of your patch fixing some of the
above things (and also fix CAY-1363). Can you take it from there and
install at least PostgreSQL and MySQL and try to make your tests run
on those (in addition to Oracle, HSQLDB, and anything else you might
be testing against)?
This would be of tremendous help to us, as your changes touch on JDBC
internals that are very sensitive to DB and driver type and version.
Andrus
This archive was generated by hypermail 2.0.0 : Tue Jan 12 2010 - 04:49:37 EST