Re: CAY-1354

From: Ольга Ткачев (tkachovaolg..mail.com)
Date: Thu Apr 08 2010 - 10:54:29 EDT

  • Next message: Evgeny Ryabitskiy: "Re: CAY-1354"

    Evgeny, good work. I run test after your last commit and everything work
    perfectly :) (postgres, sybase, mysql)

    2010/4/7 Ольга Ткачева <tkachovaolg..mail.com>

    > Failure trace
    >
    > junit.framework.AssertionFailedError: Expected Long, got: java.lang.Integer
    > at junit.framework.Assert.fail(Assert.java:47)
    > at junit.framework.Assert.assertTrue(Assert.java:20)
    > at
    > org.apache.cayenne.access.DataContextProcedureQueryTest.testSelectWithRowDescriptor(DataContextProcedureQueryTest.java:381)
    > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    > at
    > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
    > at
    > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
    > at java.lang.reflect.Method.invoke(Method.java:585)
    > at junit.framework.TestCase.runTest(TestCase.java:154)
    > at junit.framework.TestCase.runBare(TestCase.java:127)
    > at junit.framework.TestResult$1.protect(TestResult.java:106)
    > at junit.framework.TestResult.runProtected(TestResult.java:124)
    > at junit.framework.TestResult.run(TestResult.java:109)
    > at junit.framework.TestCase.run(TestCase.java:118)
    > at junit.framework.TestSuite.runTest(TestSuite.java:208)
    > at junit.framework.TestSuite.run(TestSuite.java:203)
    > at
    > org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit3TestReference.java:130)
    > at
    > org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
    > at
    > org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:460)
    > at
    > org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:673)
    > at
    > org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:386)
    > at
    > org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:196)
    >
    >
    >
    > 7 апреля 2010 г. 13:51 пользователь Рябицкий Евгений <
    > eryabitski..iasoft.ru> написал:
    >
    > I'm sure I'v test it over postgres.
    >>
    >> Could I see error stack trace?
    >>
    >> Evgeny.
    >>
    >>
    >>
    >> -----Original Message-----
    >> From: Ольга Ткачева [mailto:tkachovaolg..mail.com]
    >> Sent: Wednesday, April 07, 2010 12:02 PM
    >> To: de..ayenne.apache.org
    >> Subject: Re: CAY-1354
    >>
    >> Evgeny, after this commit I detected a new faild
    >>
    >> postgres, sybase, mysql (I didn't test it on sqlserver, h2, db2)
    >>
    >>
    >> testSelectWithRowDescriptor(org.apache.cayenne.access.DataContextProcedureQueryTest)
    >>
    >>
    >>
    >>
    >> 2010/4/5 Evgeny Ryabitskiy <evgeny.ryabitski..mail.com>
    >>
    >> > > Happy birthday :-)
    >> >
    >> > thx! )
    >> >
    >> >
    >> > > * 3.0-STABLE branch becomes a branch for 3.0.1 development
    >> > > * 3.0RC3 tag becomes basis for 3.0-final (we need to clone it though)
    >> > >
    >> > > This is totally fine with me. If we have last second fixes for
    >> 3.0-final,
    >> > > we'll just need to remember to add it to more branches.
    >> >
    >> > Sorry for troubles...
    >> >
    >> >
    >> > > Also please update RELEASE-NOTES files on all affected branches.
    >> >
    >> > Working on it.
    >> >
    >> > Evgeny.
    >> >
    >> >
    >> > > On Apr 5, 2010, at 5:33 PM, Evgeny Ryabitskiy wrote:
    >> > >>
    >> > >> Yes... but looks like not very clearly (2 april was my birthday)...
    >> > >> I have re-read it... so you didn't want to commit this patch...
    >> > >> Should I rollback it ?
    >> > >>
    >> > >> Evgeny.
    >> > >>
    >> > >>
    >> > >> 2010/4/5 Andrus Adamchik <andru..bjectstyle.org>:
    >> > >>>
    >> > >>> Hi Evgeny,
    >> > >>>
    >> > >>> did you read my email to dev list sent on April 2?
    >> > >>>
    >> > >>> Andrus
    >> > >>>
    >> > >>> On Apr 5, 2010, at 5:18 PM, evgen..pache.org wrote:
    >> > >>>
    >> > >>>> Author: evgeny
    >> > >>>> Date: Mon Apr 5 14:18:34 2010
    >> > >>>> New Revision: 930864
    >> > >>>>
    >> > >>>> URL: http://svn.apache.org/viewvc?rev=930864&view=rev
    >> > >>>> Log:
    >> > >>>> CAY-1354 Wrong Types mapping for selected values in Row Queries
    >> > >>>>
    >> > >>>> Move logic of Java type resolving from driver to Cayenne type
    >> mapping.
    >> > >>>> Reason: Drivers can return here different types (even some specific
    >> > like
    >> > >>>> com.oracle.TIMESTAMP)
    >> > >>>>
    >> > >>>> Modified:
    >> > >>>>
    >> > >>>>
    >> > >>>>
    >> >
    >> cayenne/main/branches/STABLE-3.0/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/access/jdbc/ColumnDescriptor.java
    >> > >>>>
    >> > >>>> Modified:
    >> > >>>>
    >> > >>>>
    >> >
    >> cayenne/main/branches/STABLE-3.0/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/access/jdbc/ColumnDescriptor.java
    >> > >>>> URL:
    >> > >>>>
    >> > >>>>
    >> >
    >> http://svn.apache.org/viewvc/cayenne/main/branches/STABLE-3.0/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/access/jdbc/ColumnDescriptor.java?rev=930864&r1=930863&r2=930864&view=diff
    >> > >>>>
    >> > >>>>
    >> > >>>>
    >> >
    >> ==============================================================================
    >> > >>>> ---
    >> > >>>>
    >> > >>>>
    >> >
    >> cayenne/main/branches/STABLE-3.0/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/access/jdbc/ColumnDescriptor.java
    >> > >>>> (original)
    >> > >>>> +++
    >> > >>>>
    >> > >>>>
    >> >
    >> cayenne/main/branches/STABLE-3.0/framework/cayenne-jdk1.5-unpublished/src/main/java/org/apache/cayenne/access/jdbc/ColumnDescriptor.java
    >> > >>>> Mon Apr 5 14:18:34 2010
    >> > >>>>.. -67,7 +67,7 @@ public class ColumnDescriptor implements
    >> > >>>> this.name = columnName;
    >> > >>>> this.dataRowKey = columnName;
    >> > >>>> this.jdbcType = jdbcType;
    >> > >>>> - this.javaClass = javaClass;
    >> > >>>> + this.javaClass = TypesMapping.getJavaBySqlType(jdbcType);
    >> > >>>> }
    >> > >>>>
    >> > >>>> /**
    >> > >>>>
    >> > >>>>
    >> > >>>>
    >> > >>>
    >> > >>>
    >> > >>
    >> > >
    >> > >
    >> >
    >>
    >>
    >>
    >> --
    >> Olga Tkacheva
    >>
    >
    >
    >
    > --
    > Olga Tkacheva
    >

    -- 
    Olga Tkacheva
    



    This archive was generated by hypermail 2.0.0 : Thu Apr 08 2010 - 10:55:15 EDT