During release testing found one practical reason why we want to keep
OS X logic in an OS X module, and not in the main Modeler module.
Cross-platform Modeler misses Preferences and About menu. Not the end
of the world (as there is a Mac version available), but sort of an
example of what I meant.
Andrus
On Jan 8, 2008, at 4:51 PM, Michael Gentry wrote:
> I suppose I should've mentioned MacOSXMain. Sorry about that. I have
> a separate Eclipse cayenne-modeler-mac project just to run that part
> of the code. I don't think the changes hurt the Windows/Linux
> versions.
>
> I went for the quick, easy, practical fix, not necessarily the
> "correct" fix. It just seemed the easiest way to do it at the time.
> I didn't want those menu items to appear there on the Mac, so I made
> them conditional.
>
> Thanks,
>
> /dev/mrg
>
>
> On Jan 8, 2008 9:35 AM, Andrus Adamchik <andru..bjectstyle.org>
> wrote:
>>
>> On Jan 8, 2008, at 4:27 PM, Michael Gentry wrote:
>>
>>> It is
>>> still usable and runnable inside Eclipse (preferences, about, and
>>> quit
>>> all work, they are just under the application menu).
>>
>>
>> My bad - I started the app from generic Main class. Now running from
>> MacOSXMain, I see those menu items.
>>
>>> I'm not sure moving
>>> the code out will be more beneficial -- you'd either have to
>>> entirely
>>> duplicate the menu creation code or go remove things afterwards that
>>> you don't want. This would add more clutter than just conditionally
>>> not adding the menu items in the first place.
>>
>> Splitting menu creation into a bunch of separate methods in a
>> superclass should allow to override some of them in the subclass.
>> This
>> still seems like the right thing to do, but considering the above, it
>> becomes very low priority on my list...
>>
>> Thanks,
>> Andrus
>>
>>
>>
>>
>
This archive was generated by hypermail 2.0.0 : Thu Jan 31 2008 - 06:10:08 EST